Main task for module5. by Fentezi3 · Pull Request #13 · Fentezi3/Java

Fentezi3 · 2020-11-15T11:50:55Z

No description provided.

dKatechev · 2020-11-16T10:51:18Z

.gitignore

 .idea/
-Java.iml
+Java.iml
+module5/module5.iml


Please use wildcards for .iml files instead of hardcoded values.

module5/src/main/java/Main.java

dKatechev · 2020-11-16T11:27:19Z

module5/src/main/java/Main.java

+
+    private static void validateFacultyGroupStudentsSubjectIsEmpty(List<Faculty> facultyList) throws MyException {
+        if (facultyList.isEmpty()) {
+            throw new EmptyFacultyListException("You haven't faculty in university.");


There is no faculties in university instead of You haven't ...

dKatechev · 2020-11-16T11:27:31Z

module5/src/main/java/Main.java

+        }
+        for (Faculty faculty : facultyList) {
+            if (faculty.getGroups().isEmpty()) {
+                throw new EmptyFacultyGroupsException("You haven't group in " + faculty.getFacultyName() + " faculty");


There is no...

dKatechev · 2020-11-16T11:27:44Z

module5/src/main/java/Main.java

+            }
+            for (Group group : faculty.getGroups()) {
+                if (group.getStudentsList().isEmpty()) {
+                    throw new EmptyStudentListException("You haven't students in " + group.getGroupName() + " group.");


There is no...

dKatechev · 2020-11-16T12:18:21Z

module5/src/main/java/Main.java

+            for (Group group : faculty.getGroups()) {
+                for (Student students : group.getStudentsList()) {
+                    if (students.getSubjects().containsKey(enteredSubject)) {
+                        sum += students.getSubjects().get(enteredSubject);


You call student.getSubjects() two times.
Create variable for this before if block.

dKatechev · 2020-11-16T12:18:52Z

module5/src/main/java/Main.java

+                "group, for " + subjectName + " is - " + average);
+    }
+
+    private static void averageGradeForOneSubjectInUniversity(List<Faculty> facultyList, String enteredSubject) {


enteredSubject?

dKatechev · 2020-11-16T12:22:47Z

module5/src/main/java/bean/MyException.java

@@ -0,0 +1,4 @@
+package bean;
+
+public abstract class MyException extends Exception {


Create constructor:

protected MyException(String message) { super(message); }

dKatechev · 2020-11-16T12:23:18Z

module5/src/main/java/bean/MyException.java

@@ -0,0 +1,4 @@
+package bean;


move all exceptions to separate package

dKatechev · 2020-11-16T12:24:18Z

module5/src/main/java/bean/EmptySubjectException.java

+package bean;
+
+public class EmptySubjectException extends MyException {
+    private final String studentName;


No need to use this field.
Just create constructor:

public EmptySubjectException(String message) { super(message); }

Here and in other custom messages.

module5/src/main/java/Main.java

dKatechev · 2020-11-21T11:57:54Z

module5/src/main/java/Main.java

+    /**
+     * Validation what this data is not null.
+     *
+     * @param facultyList all faculty in university.


all faculties...

dKatechev · 2020-11-21T11:59:26Z

module5/src/main/java/Main.java

+        }
+        for (Faculty faculty : facultyList) {
+            if (faculty.getGroups().isEmpty()) {
+                throw new EmptyFacultyGroupsException("There is no group in " + faculty.getName() + " faculty");


Sorry, There are no groups...

dKatechev · 2020-11-21T11:59:43Z

module5/src/main/java/Main.java

+            }
+            for (Group group : faculty.getGroups()) {
+                if (group.getStudentList().isEmpty()) {
+                    throw new EmptyStudentListException("There is no students in " + group.getName() + " group.");


Sorry, There are no students...

dKatechev · 2020-11-21T12:00:14Z

module5/src/main/java/Main.java

+                }
+                for (Student students : group.getStudentList()) {
+                    if (students.getSubjects().isEmpty()) {
+                        throw new EmptySubjectException("There is " + students.getName() + " no subjects");


Sorry, There is a student ... with no subjects
or Student ... has no subjects

dKatechev · 2020-11-21T12:03:01Z

module5/src/main/java/exceptions/EmptyStudentListException.java

+package exceptions;
+
+public class EmptyStudentListException extends MyException {
+


redundant empty line

dKatechev · 2020-11-21T12:03:10Z

module5/src/main/java/exceptions/EmptyFacultyGroupsException.java

+package exceptions;
+
+public class EmptyFacultyGroupsException extends MyException {
+


redundant empty line

dKatechev · 2020-11-21T12:03:32Z

module5/src/main/java/bean/Student.java

+
+    @Override
+    public String toString() {
+        return "Students{" +


"Student{...

dKatechev · 2020-11-21T12:06:04Z

module5/src/main/java/Main.java

+            System.out.println();
+            calculateAverageGradeForOneSubjectInUniversity(facultyList, "Math");
+        } catch (MyException e) {
+            e.getStackTrace();


Does this catch block log error message?

module5/src/main/java/Main.java

dKatechev · 2020-11-26T11:42:09Z

module5/src/main/java/Main.java

+        List<Faculty> emptyFacultyList = emptyFacultyList();
+        List<Faculty> facultyWithoutGroup = facultyWithoutGroup();
+        List<Faculty> groupWithoutStudents = groupWithoutStudents();
+        List<Faculty> studentWithoutSubjects = studentWithoutSubjects();


Now please create List of Lists and do in for loop the next:

validate each list

calculate each list's average values (all three methods should be called)

Main task for module5.

675fef4

Fentezi3 requested a review from dKatechev November 15, 2020 11:50

Ignore .iml file

5b226c5

dKatechev reviewed Nov 16, 2020

View reviewed changes

Kseniya Ramizonava added 2 commits November 19, 2020 16:11

Correction without testing data tast

dab66ff

Module5 task with corrections

0793357

dKatechev reviewed Nov 21, 2020

View reviewed changes

Fentezi3 and others added 4 commits November 22, 2020 23:37

Merge branch 'main' into module5

9b3e7c6

Resolved conflict and add corrects

c27a5ad

Merge branch 'module5' of github.com:Fentezi3/Java into module5

fc6f310

Variate facultyLists for all exceptions

2a0c13c

dKatechev reviewed Nov 26, 2020

View reviewed changes

Lists refactoring

24cfc65

Fentezi3 merged commit 12fcc2f into main Nov 26, 2020

		@@ -0,0 +1,4 @@
		package bean;

		public abstract class MyException extends Exception {

		package exceptions;

		public class EmptyStudentListException extends MyException {

		package exceptions;

		public class EmptyFacultyGroupsException extends MyException {

Conversation

Fentezi3 commented Nov 15, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants